Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Save Xenon's metadata to persistent storage. #406 #413

Merged
merged 1 commit into from
Mar 29, 2022
Merged

*: Save Xenon's metadata to persistent storage. #406 #413

merged 1 commit into from
Mar 29, 2022

Conversation

runkecheng
Copy link
Collaborator

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #406

What this PR does?

Summary:

MySQL and Xenon mount the same volume but use different subpath.

     containers:
        - name: mysql
           volumeMounts:
              mountPath: /var/lib/mysql
              subPath: mysql
              ...
        - name: xenon
           volumeMounts:
              mountPath: /var/lib/xenon
              subPath: xenon

Xenon cannot see MySQL dir.

 kubectl exec -it sample-mysql-0 -c xenon -- ls /var/lib/
apk     misc    udhcpd  xenon

MySQL cannot see Xenon dir.

kubectl exec -it sample-mysql-0 -c mysql -- ls /var/lib/
alternatives  dnf        misc         mysql-keyring  rpm        systemd
dbus          games      mysql        portables      rpm-state
dhclient      initramfs  mysql-files  private        selinux

Special notes for your reviewer?

@runkecheng runkecheng added the enhancement New feature or request label Mar 15, 2022
@runkecheng runkecheng added this to the v2.1.3 milestone Mar 15, 2022
@runkecheng runkecheng self-assigned this Mar 15, 2022
@runkecheng runkecheng force-pushed the save_xenon_metadata branch from e1c2ead to 87aed49 Compare March 15, 2022 10:27
@andyli029 andyli029 modified the milestones: v2.1.3, Next, v2.1.4 Mar 17, 2022
@acekingke
Copy link
Contributor

LGTM

andyli029
andyli029 reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit a6386c7 into radondb:main Mar 29, 2022
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this pull request Apr 11, 2022
@runkecheng
*: Save Xenon's metadata to persistent storage. radondb#406
fc22e66 
Revert "Merge pull request radondb#413 from runkecheng/save_xenon_metadata"

This reverts commit a6386c7, reversing
changes made to f6932c6.

Subpath does not work in some environments, so we decided to share DATA storage volumes directly.
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this pull request Apr 11, 2022
@runkecheng
*: Save Xenon's metadata to persistent storage. radondb#406
06d5bc0 
Revert "Merge pull request radondb#413 from runkecheng/save_xenon_metadata"

This reverts commit a6386c7, reversing
changes made to f6932c6.

Subpath does not work in some environments, so we decided to share DATA storage volumes directly.
runkecheng added a commit to runkecheng/radondb-mysql-kubernetes that referenced this pull request Apr 12, 2022
@runkecheng
Revert "Merge pull request radondb#413 from runkecheng/save_xenon_met…
3375b1c 
…adata"

This reverts commit a6386c7, reversing
changes made to f6932c6.
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#413 from runkecheng/save_xenon_metadata
025b3ac 
*: Save Xenon's metadata to persistent storage. radondb#406
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@runkecheng
Revert "Merge pull request radondb#413 from runkecheng/save_xenon_met…
e08f93d 
…adata"

This reverts commit a6386c7, reversing
changes made to f6932c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 left review comments

@acekingke acekingke Awaiting requested review from acekingke

@qianfen2021 qianfen2021 Awaiting requested review from qianfen2021

Assignees

@runkecheng runkecheng

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.1.4
Development

Successfully merging this pull request may close these issues.

[feature] Save Xenon's metadata to persistent storage.
3 participants
@runkecheng @acekingke @andyli029